[U-Boot] [PATCH 2/2] spi: kirkwood: Full dm conversion

Jagan Teki jagannadh.teki at gmail.com
Tue Mar 20 15:06:14 UTC 2018


On Tue, Mar 20, 2018 at 7:19 PM, Stefan Roese <sr at denx.de> wrote:
> Hi Jagan,
>
>
> On 15.03.2018 12:33, Jagan Teki wrote:
>>
>> kirkwood now support dt along with platform data,
>> respective boards need to switch into dm for the same.
>>
>> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
>> ---
>>   drivers/spi/kirkwood_spi.c              | 240
>> ++++++--------------------------
>>   include/dm/platform_data/spi_kirkwood.h |  15 ++
>>   2 files changed, 56 insertions(+), 199 deletions(-)
>>   create mode 100644 include/dm/platform_data/spi_kirkwood.h

snip

>> +
>> +struct mvebu_spi_platdata {
>> +       struct kwspi_registers *spireg;
>> +       bool is_errata_50mhz_ac;
>> +};
>> +
>> +#endif /* __spi_kirkwood_h */
>>
>
> So you are removing non-DM support from the SPI driver, which breaks
> current Kirkwood board using this SPI driver (e.g. inetspace_v2).
> Are you aware of this breakage?

Yes, we have migration plan for DM_SPI and DM_SPI_FLASH [1] I have
converted this to expect the board MAINTAINERS do switch DM before the
deadline. I will not apply until all used boards moved or deadline
expire.

[1] doc/driver-model/MIGRATION.txt

Jagan.
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.


More information about the U-Boot mailing list