[U-Boot] [PATCH 2/2] spi: kirkwood: Full dm conversion

Stefan Roese sr at denx.de
Tue Mar 20 15:14:24 UTC 2018


Hi Jagan,

On 20.03.2018 16:06, Jagan Teki wrote:
> On Tue, Mar 20, 2018 at 7:19 PM, Stefan Roese <sr at denx.de> wrote:
>> Hi Jagan,
>>
>>
>> On 15.03.2018 12:33, Jagan Teki wrote:
>>>
>>> kirkwood now support dt along with platform data,
>>> respective boards need to switch into dm for the same.
>>>
>>> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
>>> ---
>>>    drivers/spi/kirkwood_spi.c              | 240
>>> ++++++--------------------------
>>>    include/dm/platform_data/spi_kirkwood.h |  15 ++
>>>    2 files changed, 56 insertions(+), 199 deletions(-)
>>>    create mode 100644 include/dm/platform_data/spi_kirkwood.h
> 
> snip
> 
>>> +
>>> +struct mvebu_spi_platdata {
>>> +       struct kwspi_registers *spireg;
>>> +       bool is_errata_50mhz_ac;
>>> +};
>>> +
>>> +#endif /* __spi_kirkwood_h */
>>>
>>
>> So you are removing non-DM support from the SPI driver, which breaks
>> current Kirkwood board using this SPI driver (e.g. inetspace_v2).
>> Are you aware of this breakage?
> 
> Yes, we have migration plan for DM_SPI and DM_SPI_FLASH [1] I have
> converted this to expect the board MAINTAINERS do switch DM before the
> deadline. I will not apply until all used boards moved or deadline
> expire.

Then please Cc the board maintainers of these boards that will break
here, so that they are aware (again) of this migration and can possibly
take some action.

Thanks,
Stefan


More information about the U-Boot mailing list