[U-Boot] [PATCH] env: Properly check for BLK support

Simon Glass sjg at chromium.org
Fri Mar 30 08:42:11 UTC 2018


On 23 March 2018 at 05:53, Sjoerd Simons <sjoerd.simons at collabora.co.uk> wrote:
> Use CONFIG_IS_ENABLED to see if CONFIG_BLK is enabled. Otherwise
> SPL compilation breaks on boards which do have CONFIG_BLK enabled but
> not DM_MMC for the SPL as follows:
>
> env/mmc.c: In function ‘init_mmc_for_env’:
> env/mmc.c:164:6: warning: implicit declaration of function ‘blk_get_from_parent’; did you mean ‘efi_get_ram_base’? [-Wimplicit-function-declaration]
>   if (blk_get_from_parent(mmc->dev, &dev))
>       ^~~~~~~~~~~~~~~~~~~
>       efi_get_ram_base
> env/mmc.c:164:29: error: ‘struct mmc’ has no member named ‘dev’
>   if (blk_get_from_parent(mmc->dev, &dev))
>                              ^~
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> ---
>
>  env/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list