[U-Boot] [PATCH v3 2/6] ARM: mvebu: a38x: move sys_env_device_rev_get
Chris Packham
judge.packham at gmail.com
Thu May 10 01:28:27 UTC 2018
Move sys_env_device_rev_get() from the ddr training code to
sys_env_lib.c (which currently resides with the serdes code). This
brings sys_env_device_rev_get() into line with sys_env_device_id_get()
and sys_env_model_get().
Signed-off-by: Chris Packham <judge.packham at gmail.com>
---
Changes in v3: None
Changes in v2:
- remove unused #include
arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c | 26 +++++++++++++++++--
arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h | 1 -
drivers/ddr/marvell/a38x/ddr3_init.c | 24 -----------------
3 files changed, 24 insertions(+), 27 deletions(-)
diff --git a/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c b/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c
index d26068e1d774..d387893af37d 100644
--- a/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c
+++ b/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c
@@ -12,8 +12,6 @@
#include "seq_exec.h"
#include "sys_env_lib.h"
-#include "../../../drivers/ddr/marvell/a38x/ddr3_a38x.h"
-
#ifdef CONFIG_ARMADA_38X
enum unit_id sys_env_soc_unit_nums[MAX_UNITS_ID][MAX_DEV_ID_NUM] = {
/* 6820 6810 6811 6828 */
@@ -234,3 +232,27 @@ u32 sys_env_device_id_get(void)
return g_dev_id;
}
+
+/*
+ * sys_env_device_rev_get - Get Marvell controller device revision number
+ *
+ * DESCRIPTION:
+ * This function returns 8bit describing the device revision as defined
+ * Revision ID Register.
+ *
+ * INPUT:
+ * None.
+ *
+ * OUTPUT:
+ * None.
+ *
+ * RETURN:
+ * 8bit desscribing Marvell controller revision number
+ */
+u8 sys_env_device_rev_get(void)
+{
+ u32 value;
+
+ value = reg_read(DEV_VERSION_ID_REG);
+ return (value & (REVISON_ID_MASK)) >> REVISON_ID_OFFS;
+}
diff --git a/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h b/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h
index c5461067fd88..953445b7d7ae 100644
--- a/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h
+++ b/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h
@@ -7,7 +7,6 @@
#define _SYS_ENV_LIB_H
#include "../../../drivers/ddr/marvell/a38x/ddr3_init.h"
-#include "../../../drivers/ddr/marvell/a38x/ddr3_hws_hw_training.h"
/* Serdes definitions */
#define COMMON_PHY_BASE_ADDR 0x18300
diff --git a/drivers/ddr/marvell/a38x/ddr3_init.c b/drivers/ddr/marvell/a38x/ddr3_init.c
index 6ee13c10e493..1c5b1f75ca4f 100644
--- a/drivers/ddr/marvell/a38x/ddr3_init.c
+++ b/drivers/ddr/marvell/a38x/ddr3_init.c
@@ -107,30 +107,6 @@ static int ddr3_hws_tune_training_params(u8 dev_num);
/* A39x revisions */
#define MV_88F69XX_Z1_ID 0x2
-/*
- * sys_env_device_rev_get - Get Marvell controller device revision number
- *
- * DESCRIPTION:
- * This function returns 8bit describing the device revision as defined
- * Revision ID Register.
- *
- * INPUT:
- * None.
- *
- * OUTPUT:
- * None.
- *
- * RETURN:
- * 8bit desscribing Marvell controller revision number
- */
-u8 sys_env_device_rev_get(void)
-{
- u32 value;
-
- value = reg_read(DEV_VERSION_ID_REG);
- return (value & (REVISON_ID_MASK)) >> REVISON_ID_OFFS;
-}
-
/*
* sys_env_dlb_config_ptr_get
*
--
2.17.0
More information about the U-Boot
mailing list