[U-Boot] [PATCH v2] timer: Add Cadence TTC timer counter support

[Simon Glass]

On 10 May 2018 at 18:24, Michal Simek <michal.simek at xilinx.com> wrote:
> This driver was tested on Xilinx ZynqMP SoC.
>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
>
> Changes in v2:
> - Remove tabs from U_BOOT_DRIVER
>
>  MAINTAINERS                 |  1 +
>  drivers/timer/Kconfig       |  7 +++
>  drivers/timer/Makefile      |  1 +
>  drivers/timer/cadence-ttc.c | 91 +++++++++++++++++++++++++++++++++++++
>  4 files changed, 100 insertions(+)
>  create mode 100644 drivers/timer/cadence-ttc.c

Reviewed-by: Simon Glass <sjg at chromium.org>

But please see below.

[...]

> +static int cadence_ttc_ofdata_to_platdata(struct udevice *dev)
> +{
> +       struct cadence_ttc_priv *priv = dev_get_priv(dev);
> +
> +       priv->regs = map_physmem(devfdt_get_addr(dev),
> +                                sizeof(struct cadence_ttc_regs), MAP_NOCACHE);

Please use dev_read_addr() and other live-tree functions.

Regards,
Simon