[U-Boot] [U-Boot, v4, 09/32] tpm: prepare introduction of TPMv2.x support in Kconfig

Miquel Raynal miquel.raynal at bootlin.com
Sun May 27 22:22:50 UTC 2018


Hi Tom,

On Sat, 26 May 2018 11:54:29 -0400, Tom Rini <trini at konsulko.com> wrote:

> On Tue, May 15, 2018 at 11:57:05AM +0200, Miquel Raynal wrote:
> 
> > Because both major revisions are not compatible at all, let's make them
> > mutually exclusive in Kconfig. This way we will be sure, when using a
> > command or a library function that it is supported by the right
> > revision.
> > 
> > Current drivers are currently prefixed by "tpm_", we will prefix TPMv2.x
> > files by "tpm2_" to make the distinction without moving everything.
> > 
> > The Kconfig menu about TPM drivers is now divided into two sections, one
> > for each specification. Compliant drivers with one specification will
> > only show up if this specification _only_ has been selected, otherwise a
> > comment is displayed.
> > 
> > Once a driver is selected by the user, it selects automatically a
> > boolean value, that is needed in order to activate the TPM commands.
> > Selecting the TPM commands will automatically select the right
> > command/library files.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > Reviewed-by: Tom Rini <trini at konsulko.com>  
> 
> There was a thinko in here that I noticed when building for everything,
> that I have fixed.  Both TPM_V1 and TPM_V2 need to depend on TPM (which
> comes from lib/Kconfig) otherwise we would start building TPMv1 support
> for all platforms.  I also ended up dropping out TPM_DRIVER_SELECTED and
> instead making CMD_TPM depend on TPM_V1 || TPM_V2 as that ended up being
> a cleaner way to deal with the gdsys boards with TPM but without a
> dedicated driver exactly.  With that fixed:
> 
> Applied to u-boot/master, thanks!
> 

Ok, thanks for the update.

Nice to see all that series merged!

Regards,
Miquèl


More information about the U-Boot mailing list