[U-Boot] [PATCH 22/30] riscv: remove unused labels in start.S

Rick Chen rickchen36 at gmail.com
Wed Oct 24 02:38:25 UTC 2018


> > > The labels nmi_vector, trap_vector and handle_reset in start.S are not
> > > used for RISC-V. Remove them.
> > >

Hi Lukas

Agree with the above part.

> > > While we are here, also remove the code from the beginning of start.S,
> > > which stores the contents of a2 to memory. Only registers a0 and a1
> > > contain information from the previous boot stage. There is therefore
> > > no reason for saving a2.

NOT agree with this part.
Saving a2 is trying to support dynamically dtb pass at runtime.

You can see it in the following commit :

commit d58717e42559189a226ea800173147399c8edef9
Author: Rick Chen <rick at andestech.com>
Date:   Thu Mar 29 10:08:33 2018 +0800

    riscv: ae250: Support DT provided by the board at runtime

B.R
Rick

> > >
> > > Signed-off-by: Lukas Auer <lukas.auer at aisec.fraunhofer.de>
> > > ---
> > >
> > >  arch/riscv/cpu/start.S | 11 -----------
> > >  1 file changed, 11 deletions(-)
> > >
> >
> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list