[U-Boot] [PATCH 22/30] riscv: remove unused labels in start.S

[Bin Meng]

Hi Rich,

On Wed, Oct 24, 2018 at 10:37 AM Rick Chen <rickchen36 at gmail.com> wrote:
>
> > > > The labels nmi_vector, trap_vector and handle_reset in start.S are not
> > > > used for RISC-V. Remove them.
> > > >
>
> Hi Lukas
>
> Agree with the above part.
>
> > > > While we are here, also remove the code from the beginning of start.S,
> > > > which stores the contents of a2 to memory. Only registers a0 and a1
> > > > contain information from the previous boot stage. There is therefore
> > > > no reason for saving a2.
>
> NOT agree with this part.
> Saving a2 is trying to support dynamically dtb pass at runtime.
>

Could you please describe in more details on what the use case is here?

> You can see it in the following commit :
>
> commit d58717e42559189a226ea800173147399c8edef9
> Author: Rick Chen <rick at andestech.com>
> Date:   Thu Mar 29 10:08:33 2018 +0800
>
>     riscv: ae250: Support DT provided by the board at runtime
>

Regards,
Bin