[U-Boot] [PATCH 22/30] riscv: remove unused labels in start.S

[Rick Chen]

Bin Meng <bmeng.cn at gmail.com> 於 2018年10月24日 週三 上午11:34寫道：
>
> Hi Rich,
>
> On Wed, Oct 24, 2018 at 10:37 AM Rick Chen <rickchen36 at gmail.com> wrote:
> >
> > > > > The labels nmi_vector, trap_vector and handle_reset in start.S are not
> > > > > used for RISC-V. Remove them.
> > > > >
> >
> > Hi Lukas
> >
> > Agree with the above part.
> >
> > > > > While we are here, also remove the code from the beginning of start.S,
> > > > > which stores the contents of a2 to memory. Only registers a0 and a1
> > > > > contain information from the previous boot stage. There is therefore
> > > > > no reason for saving a2.
> >
> > NOT agree with this part.
> > Saving a2 is trying to support dynamically dtb pass at runtime.
> >
>
> Could you please describe in more details on what the use case is here?
>

Hi Bin and Lukas

After I study [PATCH 24/30] riscv: save hart ID and device tree passed
by prior boot stage.
I found it is the same thing.
I will accepted this patch.
So this patch is

Reviewed-by: Rick Chen <rick at andestech.com>

But I shall send a patch to fix ax25-ae350 to work as well later.
And it will be as below :

ax5-ae350.c
void *board_fdt_blob_setup(void)
{
void **ptr = (void *)&prior_stage_fdt_address;
if (fdt_magic(*ptr) == FDT_MAGIC)
return (void *)*ptr;

return (void *)CONFIG_SYS_FDT_BASE;
}


> > You can see it in the following commit :
> >
> > commit d58717e42559189a226ea800173147399c8edef9
> > Author: Rick Chen <rick at andestech.com>
> > Date:   Thu Mar 29 10:08:33 2018 +0800
> >
> >     riscv: ae250: Support DT provided by the board at runtime
> >
>
> Regards,
> Bin