want to confirm that include/configs/xilinx_zynqmp*.h files seem unused
Michal Simek
monstr at monstr.eu
Fri Dec 13 15:50:21 CET 2019
On 13. 12. 19 15:05, Robert P. J. Day wrote:
>
> been a while since i wandered through the innards of u-boot so it's
> possible this is a silly question.
>
> was just placed on a project that involves a xilinx zynqmp-based
> board, and need to upgrade the version of u-boot that's currently
> being used. as part of my perusal, i did a quick grep to see what
> existing boards were doing with any zynqmp-related header files, so i
> did this from the top of the current tree:
>
> $ grep -r "include.*xilinx_zynqmp.*\.h" *
> include/configs/xilinx_zynqmp_mini.h:#include <configs/xilinx_zynqmp.h>
> include/configs/xilinx_zynqmp_mini_emmc.h:#include <configs/xilinx_zynqmp_mini.h>
> include/configs/xilinx_zynqmp_mini_qspi.h:#include <configs/xilinx_zynqmp_mini.h>
> include/configs/xilinx_zynqmp_mini_nand.h:#include <configs/xilinx_zynqmp_mini.h>
> $
>
> i'm aware of the ongoing migration of content from
> include/configs/*.h files to defconfig files, so the above seems to
> suggest, given the circular inclusion of those header files with no
> one else including them, that those files are no longer referenced.
>
> my guess is that all that content was migrated to defconfigs but the
> header files were simply left there. is that a fair conclusion, or
> might there be something far more subtle i'm overlooking here?
Nope.
All of them are used as configuration for configs/xilinx_zynqmp_mini*
configurations.
But as I am looking at it SYS_MALLOC_LEN can be converted to Kconfig.
The rest - SYS_SDRAM_SIZE/BASE and SYS_INIT_SP_ADDR haven't been
converted yet. But patches welcome. Then we can remove _emmc, _qspi,
_nand configurations and keep just mini.h one till other stuff are
converted.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191213/dc856012/attachment.sig>
More information about the U-Boot
mailing list