[v2] armv8: fsl-layerscape: Kconfig: Correct I2C dependecies

Biwen Li biwen.li at nxp.com
Mon Dec 23 12:53:17 CET 2019



> -----Original Message-----
> From: Jagdish Gediya <jagdish.gediya at nxp.com>
> Sent: 2019年12月23日 18:22
> To: Biwen Li <biwen.li at nxp.com>; Priyanka Jain <priyanka.jain at nxp.com>
> Cc: u-boot at lists.denx.de; Jiafei Pan <jiafei.pan at nxp.com>; Biwen Li
> <biwen.li at nxp.com>
> Subject: RE: [v2] armv8: fsl-layerscape: Kconfig: Correct I2C dependecies
> 
> Hi Biwen,
> 
> > -----Original Message-----
> > From: Biwen Li <biwen.li at nxp.com>
> > Sent: Monday, December 23, 2019 12:09 PM
> > To: Priyanka Jain <priyanka.jain at nxp.com>; Jagdish Gediya
> > <jagdish.gediya at nxp.com>
> > Cc: u-boot at lists.denx.de; Jiafei Pan <jiafei.pan at nxp.com>; Biwen Li
> > <biwen.li at nxp.com>
> > Subject: [v2] armv8: fsl-layerscape: Kconfig: Correct I2C dependecies
> >
> > Don't select SYS_I2C_MXC_I2C* when DM_I2C is enabled. This is required
> > to resolve below warnings while 'make *defconfig'
> >
> > 	ARCH_LS1046A [=y] && ARM [=y]
> > 	WARNING: unmet direct dependencies detected for
> > SYS_I2C_MXC_I2C3
> > 	Depends on [n]: SYS_I2C_MXC [=y] && (!DM_I2C [=y] || SPL [=n])
> > 	Selected by [y]:
> >
> > Signed-off-by: Biwen Li <biwen.li at nxp.com>
> > ---
> > Change in v2:
> > 	- update subject and descriptions
> >
> >  arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 20 ++++++++++----------
> These changes are not required in upstream as this issue caused by
> http://patchwork.ozlabs.org/patch/1213011/ and it is not accepted yet.
> Merge these changes with http://patchwork.ozlabs.org/patch/1213011/.
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > index f1578b10bc..84ece4d587 100644
> > --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > @@ -16,8 +16,8 @@ config ARCH_LS1012A
> >  	select ARCH_EARLY_INIT_R
> >  	select BOARD_EARLY_INIT_F
> >  	select SYS_I2C_MXC
> > -	select SYS_I2C_MXC_I2C1
> > -	select SYS_I2C_MXC_I2C2
> > +	select SYS_I2C_MXC_I2C1 if !DM_I2C
> > +	select SYS_I2C_MXC_I2C2 if !DM_I2C
> >  	imply PANIC_HANG
> Merge above changes in http://patchwork.ozlabs.org/patch/1213016/
Ok, I will merge it in v6
> >
> >  config ARCH_LS1028A
> > @@ -75,10 +75,10 @@ config ARCH_LS1043A
> >  	select ARCH_EARLY_INIT_R
> >  	select BOARD_EARLY_INIT_F
> >  	select SYS_I2C_MXC
> > -	select SYS_I2C_MXC_I2C1
> > -	select SYS_I2C_MXC_I2C2
> > -	select SYS_I2C_MXC_I2C3
> > -	select SYS_I2C_MXC_I2C4
> > +	select SYS_I2C_MXC_I2C1 if !DM_I2C
> > +	select SYS_I2C_MXC_I2C2 if !DM_I2C
> > +	select SYS_I2C_MXC_I2C3 if !DM_I2C
> > +	select SYS_I2C_MXC_I2C4 if !DM_I2C
> >  	imply CMD_PCI
> Merge above changes in http://patchwork.ozlabs.org/patch/1213017/
Ok, I will merge it in v6.
> >
> >  config ARCH_LS1046A
> > @@ -108,10 +108,10 @@ config ARCH_LS1046A
> >  	select ARCH_EARLY_INIT_R
> >  	select BOARD_EARLY_INIT_F
> >  	select SYS_I2C_MXC
> > -	select SYS_I2C_MXC_I2C1
> > -	select SYS_I2C_MXC_I2C2
> > -	select SYS_I2C_MXC_I2C3
> > -	select SYS_I2C_MXC_I2C4
> > +	select SYS_I2C_MXC_I2C1 if !DM_I2C
> > +	select SYS_I2C_MXC_I2C2 if !DM_I2C
> > +	select SYS_I2C_MXC_I2C3 if !DM_I2C
> > +	select SYS_I2C_MXC_I2C4 if !DM_I2C
> >  	imply SCSI
> >  	imply SCSI_AHCI
> Merge above changes in http://patchwork.ozlabs.org/patch/1213018/
Ok, I will merge it in v6
> 
> --Jagdish


More information about the U-Boot mailing list