[U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

[Philipp Tomsich]

> On 01.02.2019, at 09:38, Philipp Tomsich <philipp.tomsich at theobroma-systems.com> wrote:
> 
> Andy,
> 
>> On 01.02.2019, at 02:32, andy.yan at rock-chips.com wrote:
>> 
>> Hi：
>> 
>>> This function causes a 5-second delay and stops the display working on
>>> minnie. This code should be in a driver and should only be enabled by
>>> a device-tree property, so that it does not affect devices which do not
>>> have this feature.
>>> 
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>>> ---
>>> 
>>> arch/arm/mach-rockchip/boot_mode.c | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>> 
>> 
>> 》Applied to u-boot-rockchip, thanks!
>> 
>> 
>> According to the previous discussing， shouldn‘t this be fixed by  by setting CONFIG_BOOT_MODE_REG=0 ？
>> All rockchip products need this function，we really don't want it be turned off.
> 
> The actual decision was that this needed to be converted to the driver-model.
> Setting CONFIG_BOOT_MODE_REG=0 was a workaround that we used only
> for 2019.1, so I could delay applying Simon’s patch until this cycle.

Just for the record, this is a verbatim quote from the original review:
> If this works for you, we can avoid removing this feature this late in the cycle and
> defeature/remove it in the next release, unless moved into a DTS-controlled driver.

> 
> Please convert this into a DM driver, so we can add the driver for 2019.4.
> 
> Thanks,
> Philipp.
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot