[U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces at lists.denx.de代发】

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Fri Feb 1 09:34:59 UTC 2019



> On 01.02.2019, at 10:32, Kever Yang <kever.yang at rock-chips.com> wrote:
> 
> Hi Philipp,
> 
>     This is not right,  this patch should not merged like this!!!
> 
>     I have give my review comment in previous mail, and this will break
> many boards.
> 
>     My another patch do not break anything, but you insist NAK it
> without acceptable reason;

What other patch?
I don’t remember seeing that one...

>     This patch definitely break other board and I have comment it, but
> you just ignore other people's review and merge it, good job!
> 
> Thanks,
> - Kever
> On 02/01/2019 05:12 AM, Philipp Tomsich wrote:
>>> This function causes a 5-second delay and stops the display working on
>>> minnie. This code should be in a driver and should only be enabled by
>>> a device-tree property, so that it does not affect devices which do not
>>> have this feature.
>>> 
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>>> ---
>>> 
>>> arch/arm/mach-rockchip/boot_mode.c | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>> 
>> Applied to u-boot-rockchip, thanks!
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> https://lists.denx.de/listinfo/u-boot
> 
> 
> 



More information about the U-Boot mailing list