[U-Boot] [PATCH 2/5] net: ethernet: ti: Introduce am654 gigabit eth switch subsystem driver

Tom Rini trini at konsulko.com
Fri Feb 1 15:17:36 UTC 2019


On Thu, Jan 31, 2019 at 11:00:29AM +0530, Keerthy wrote:

> From: Grygorii Strashko <grygorii.strashko at ti.com>
> 
> Add new driver for the TI AM65x SoC Gigabit Ethernet Switch subsystem (CPSW
> NUSS). It has two ports and provides Ethernet packet communication for the
> device and can be configured as an Ethernet switch. CPSW NUSS features: the
> Reduced Gigabit Media Independent Interface (RGMII), Reduced Media
> Independent Interface (RMII), and the Management Data Input/Output (MDIO)
> interface for physical layer device (PHY) management. The TI AM65x SoC has
> integrated two-port Gigabit Ethernet Switch subsystem into device MCU
> domain named MCU_CPSW0. One Ethernet port (port 1) with selectable RGMII
> and RMII interfaces and an internal Communications Port Programming
> Interface (CPPI) port (Host port 0).
> 
> Host Port 0 CPPI Packet Streaming Interface interface supports 8 TX
> channels and on RX channels operating by TI am654 NAVSS Unified DMA
> Peripheral Root Complex (UDMA-P) controller.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko at ti.com>
> Signed-off-by: Keerthy <j-keerthy at ti.com>
[snip]
> +#ifdef AM65_CPSW_DEBUG
> +#define	am65_cpsw_dbg(arg...) pr_err(arg)
> +#define	am65_cpsw_dev_dbg(dev, arg...) dev_err(dev, arg)

No new debug macros, use pr_err/etc directly and tweak CONFIG_LOGLEVEL /
CONFIG_SPL_LOGLEVEL or the macro being used if things are now too spammy
in real usage.

> +static void am65_cpsw_print_buf(ulong addr, const void *data, uint width,
> +				uint count, uint linelen)
> +{
> +	print_buffer(addr, data, width, count, linelen);
> +}

One usage of this function was clearly a bring-up debug print and for
the other, we either call print_buffer on DMA failure or we don't care
enough to.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190201/958d30a6/attachment.sig>


More information about the U-Boot mailing list