[U-Boot] [PATCH 1/2] splash: Use splashfile instead of location->name

Jonas Mark (BT-FIR/ENG1) Mark.Jonas at de.bosch.com
Mon Feb 4 13:05:47 UTC 2019

Hi Simon,

thank you for your review.

> > diff --git a/doc/README.splashprepare b/doc/README.splashprepare
> > index f1418de..c7f7493 100644
> > --- a/doc/README.splashprepare
> > +++ b/doc/README.splashprepare
> > @@ -26,6 +26,6 @@ screen data is loaded as a file. The name of the splash screen file can be
> >  controlled with the environment variable "splashfile".
> >
> >  To enable loading the splash image from a FIT image, CONFIG_FIT must be
> > -enabled. Struct splash_location field 'name' should match the splash image
> > -name within the FIT and the FIT should start at the 'offset' field address in
> > -the specified storage.
> > +enabled. The FIT image has to start at the 'offset' field address in the
> > +selected splash location. The name of splash image within the FIT shall be
> > +specified by the environment variable "splashfile".
> Can you also mention the default name?

Good proposal, we will do that.

I will wait if there is more feedback and then send an updated patch set.


Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster

More information about the U-Boot mailing list