[U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

[Joe Hershberger]

On Tue, Feb 5, 2019 at 9:20 AM Carlo Caione <ccaione at baylibre.com> wrote:
>
> On 05/02/2019 00:15, Joe Hershberger wrote:
> > On Mon, Feb 4, 2019 at 5:39 PM Vladimir Oltean <vladimir.oltean at nxp.com> wrote:
>
> /cut
> >> Which brings me to my next point.
> >> If we can't properly make the distinction between an indirect C22 MMD
> >> access and a proper C45 MMD access, and hence not keeping proper API
> >> compatibility with Linux kernel, aren't we better off going back to
> >> square 1 and using phy_read_mmd_indirect and phy_write_mmd_indirect?
> >
> > I think we can and should make the new wrapper functions remain named
> > phy_*_mmd_indirect and the names of the override functions in the phy
> > driver ops should be *_mmd_indirect. The override is still for an
> > indirect access of c45 registers, just an apparently non-standard one.
> > It is this way in Linux as well.
>
> Alright then. I'll prepare a V5.
>
> A couple on notes:
>
> 1. I'd prefer the parameters of the "mdio" command to be name "rimmd"
> and "wimmd" for "r/w indirect MMD" to keep the (twisted) logic of the
> mdio command code of differentiating the parameters according to
> argv[1][1] and r/w according to argv[1][0]

Is there a reason you want to keep the mmd in there? It seems implied
by doing any access using the mdio command.

Maybe wi and ri or windirect and rindirect or wind and rind?

> 2. Since [0] needs a respin as well after the requested changes, I'm
> going to embedded that patch into this patchset.

Sounds good.

>
> Cheers
>
> [0] https://lists.denx.de/pipermail/u-boot/2019-January/356019.html
>
> --
> Carlo Caione
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot