[U-Boot] [PATCH v2 1/7] dm: core: Add of_alias_get_highest_id()

Heiko Schocher hs at denx.de
Thu Feb 7 06:46:22 UTC 2019


Hello Michal,

Am 31.01.2019 um 16:30 schrieb Michal Simek:
> The same functionality was added to Linux for i2c bus registration with this
> commit message:
> 
> "
> of: base: add function to get highest id of an alias stem
> 
> I2C supports adding adapters using either a dynamic or fixed id. The
> latter is provided by aliases in the DT case. To prevent id collisions
> of those two types, install this function which gives us the highest
> fixed id, so we can then let the dynamically created ones come after
> this highest number.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
> Acked-by: Rob Herring <robh at kernel.org>
> Signed-off-by: Wolfram Sang <wsa at the-dreams.de>
> "
> 
> Add it also to U-Boot for DM I2C support.
> 
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
> 
> Changes in v2:
> - Update kernel-doc binding
> - Return -1 in case of error. -1 means that the next free alias is 0.
> 
>   drivers/core/of_access.c | 18 ++++++++++++++++++
>   include/dm/of_access.h   | 10 ++++++++++
>   2 files changed, 28 insertions(+)

Looks good to me

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list