[U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

[Melin Tomas]

Hi Mark,

On 2/6/19 5:42 PM, Jonas Mark (BT-FIR/ENG1) wrote:
>> If I understand the original issue you had correctly, could it also have
>> been fixed by renaming splash node in FIT image?
> Yes, that's we actually started with. But once we started adding more
> files to that FIT image we saw the problem: Then we had files in the FIT
> image with "nice" names and one "ugly duckling". Now it is fixed.

The same end result could be achieved by selecting an appropriate name 
for the 'splash_location' 'name' field, sounds like no need for new env 
variable.

But please fill in if there is something more to the original problem

>>> Why do I think so? Because the behavior is now consistent to what
>>> splash_load_fs() does. That is, if there is an environment variable
>>> "splashfile" the splash screen name is taken from there. Else, the
>>> fixed default name "splash.bmp" is used.

Except there is an important difference. This is loading a node from a 
FIT image, not a file from a file system.

The patch sets the default _node_ name to look for in the FIT to be 
"splash.bmp", that's a rather odd name for a FIT node.

>> Symmetry is nice, so ok. But still, it now rules out the possiblity to use the
>> splash name in the FIT without defining additional "splashfile"
>> to the env.
> This is not correct. In case you do not define "splashfile" in the
> environment the consistent (!) default name is "splash.bmp".

No, that's not what I meant. Prior to the change, splash node name in 
FIT could be selected freely

without adding "splashfile" to environment. That's not longer possible.

BR,

Tomas