[U-Boot] [PATCH] test: fs: Add filesystem integrity checks

[Simon Glass]

Hi Jean-Jacques,

On Fri, 8 Feb 2019 at 12:31, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
>
> + Simon
>
> On 05/02/2019 15:48, Jean-Jacques Hiblot wrote:
> >
> > On 05/02/2019 14:45, Tom Rini wrote:
> >> On Mon, Feb 04, 2019 at 12:19:19PM +0100, Jean-Jacques Hiblot wrote:
> >>> We need to make sure that file writes,file creation, etc. are properly
> >>> performed and do not corrupt the filesystem.
> >>> To help with this, introduce the assert_fs_integrity() function that
> >>> executes the appropriate fsck tool. It should be called at the end
> >>> of any
> >>> test that modifies the content/organization of the filesystem.
> >>> Currently only supports FATs and EXT4.
> >>>
> >>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
> >>> ---
> >>>
> >>> While working on symlink I had noticed the need for automated check
> >>> of the
> >>> filesystem. It indeed helped catch a few corruption problems.
> >>>
> >>> - SPOILER - this patch will turn some lights red in travis - SPOILER -
> >> Oh fun.  Do you have a link to the travis failures?  Thanks!
> >
> > Actually I was wrong. no red lights: the fs tests are skipped :/
> > Probably because they take so long to run.
> >
> > I haven't figured out how they are disabled and how to enable them.
> >
> > Nevertheless running the test at least on sandbox would be a pretty
> > good idea. It revealed some corruptions going on with FAT16 and FAT32
> >
> >
> Simon,
>
> Do you have an idea on how to enable the fs tests in travis? Not on all
> platforms but it would be nice to enable them on sandbox.

No I am not sure what is going on. The FS tests are definitely skipped
on travis, but something like:

./test/py/test.py --bd sandbox --build-dir build-sandbox --build

does run them. That appears to be what travis is using:

./test/py/test.py --bd ${TEST_PY_BD} ${TEST_PY_ID} -k
"${TEST_PY_TEST_SPEC:-not a_test_which_does_not_exist}" --build-dir
"$UBOOT_TRAVIS_BUILD_DIR";

as from what I can tell, TEST_PY_TEST_SPEC and TEST_PY_ID are empty
when running sandbox tests.

Tom is much more of an expert on this than me.

Regards,
Simon