[U-Boot] [PATCH v6 02/16] Makefile: Fix mrproper make target

[Tom Rini]

On Sun, Feb 10, 2019 at 06:31:02PM +0000, Auer, Lukas wrote:
> On Sat, 2019-02-09 at 06:31 +0000, Anup Patel wrote:
> > Currently, the mrproper make target tries to force remove all
> > "arch/*/include/asm/arch" paths assuming they are symlinks but
> > this prevents us from adding place-holder headers under the
> > arch/riscv/include/asm/arch directory.
> > 
> > To solve this, we fix mrproper make target to only remove
> > "arch/*/include/asm/arch" paths which are symlinks and do
> > nothing for paths which are directory.
> > 
> > Signed-off-by: Anup Patel <anup.patel at wdc.com>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index cf7b2b10bc..2d05b8da9a 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1782,7 +1782,7 @@ $(mrproper-dirs):
> >  mrproper: clean $(mrproper-dirs)
> >  	$(call cmd,rmdirs)
> >  	$(call cmd,rmfiles)
> > -	@rm -f arch/*/include/asm/arch
> > +	@for d in `dirname arch/*/include/asm/arch`; do if [ -L
> > $$d/arch ]; then echo "  CLEAN   "$$d/arch; rm -f $$d/arch; fi; done
> >  
> >  # distclean
> >  #
> 
> This looks good to me, but I am not familiar enough with the other
> architectures to know if this could affect them somehow. I have added
> Tom on CC. Maybe he can weigh in on this.

I'll grant there may be one, but what is the use-case for non-symlink
<asm/arch/foo.h> ?  We _shouldn't_ be forcing that in to generic code,
but might have let some users in.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190210/a7b15436/attachment.sig>