[U-Boot] [PATCH v6 05/16] riscv: Add place-holder asm/arch/clk.h for driver compilation

Anup Patel Anup.Patel at wdc.com
Mon Feb 11 04:28:52 UTC 2019



> -----Original Message-----
> From: Bin Meng [mailto:bmeng.cn at gmail.com]
> Sent: Monday, February 11, 2019 8:51 AM
> To: Anup Patel <Anup.Patel at wdc.com>
> Cc: Rick Chen <rick at andestech.com>; Joe Hershberger
> <joe.hershberger at ni.com>; Michal Simek <monstr at monstr.eu>; Michal
> Simek <michal.simek at xilinx.com>; Lukas Auer
> <lukas.auer at aisec.fraunhofer.de>; Masahiro Yamada
> <yamada.masahiro at socionext.com>; Simon Glass <sjg at chromium.org>;
> Alexander Graf <agraf at suse.de>; Palmer Dabbelt <palmer at sifive.com>;
> Paul Walmsley <paul.walmsley at sifive.com>; Atish Patra
> <Atish.Patra at wdc.com>; U-Boot Mailing List <u-boot at lists.denx.de>; Tom
> Rini <trini at konsulko.com>
> Subject: Re: [PATCH v6 05/16] riscv: Add place-holder asm/arch/clk.h for
> driver compilation
> 
> On Sat, Feb 9, 2019 at 2:31 PM Anup Patel <Anup.Patel at wdc.com> wrote:
> >
> > Some of the drivers expect asm/arch/clk.h to be provided by arch
> > support code so we add place-holder asm/arch/clk.h for RISC-V support.
> >
> > Signed-off-by: Anup Patel <anup.patel at wdc.com>
> > ---
> >  arch/riscv/include/asm/arch/clk.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 arch/riscv/include/asm/arch/clk.h
> 
> I looked at this and understand why patch [1/16] and [2/16] are needed. But
> can we do the same like other architectures, ie: creating directory
> include/asm/arch-xxx instead? Creating a hard-coded include/asm/arch
> directory prevents us from expanding SoC/platform specific support in the
> future.

Even Tom suggested similar thing. I will use CREATE_ARCH_SYMLINK
instead in next version of patchset.

Regards,
Anup


More information about the U-Boot mailing list