[U-Boot] [PATCH v4 14/20] mtd: spi: Switch to new SPI NOR framework

[Vignesh R]

On 11/02/19 9:01 AM, Adam Ford wrote:
> On Tue, Feb 5, 2019 at 12:00 AM Vignesh R <vigneshr at ti.com> wrote:
>>
>> Switch spi_flash_* interfaces to call into new SPI NOR framework via MTD
>> layer. Fix up sf_dataflash to work in legacy way. And update sandbox to
>> use new interfaces/definitions
>>
>> Signed-off-by: Vignesh R <vigneshr at ti.com>
>> Tested-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>> Tested-by: Stefan Roese <sr at denx.de>
>> Tested-by: Horatiu Vultur <horatiu.vultur at microchip.com>
>> Reviewed-by: Jagan Teki <jagan at openedev.com>
>> Tested-by: Jagan Teki <jagan at amarulasolutions.com> #zynq-microzed
> 
> This patch appears to break the da850_evm board which boots from SPI
> Flash and initializes the davinci driver with platdata since the
> device tree stuff does not quite work right in SPL.

Oops, I did test on K2G EVM that has davinci SPI controller with micron
n25q flash but that was with DT. Not sure whats missing with platdata.

> 
> U-Boot SPL 2019.01-02923-gc4e8862308-dirty (Feb 10 2019 - 21:24:38 -0600)
> Trying to boot from SPI
> SPI probe failed.
> SPL: failed to boot from all boot devices
> ### ERROR ### Please RESET the board ###

Could you enable debug prints at spi-mem level in drivers/spi/spi-mem.c
(especially debug prints at the end of spi_mem_exec_op()) and post the
logs here?

> 
> Any suggestions on how to fix the SPI initialization without needing
> the device tree?  I have tried to port the device tree stuff to SPL,
> but I haven't yet been successful so I have had to leave the platdata
> initialization in place.
> 

I haven't changed any driver names so, platdata to driver bindings
should still be the same. Could you verify if spi_nor_scan() is being
called in drivers/mtd/spi/spi-nor-tiny.c for SPL?

Sorry for the trouble.

Regards
Vignesh


-- 
Regards
Vignesh