[U-Boot] [PATCH 01/33] log: Add a Kconfig option to set the default log level

Bin Meng bmeng.cn at gmail.com
Wed Feb 13 09:36:26 UTC 2019


Hi Simon,

On Tue, Jan 22, 2019 at 9:14 AM Simon Glass <sjg at chromium.org> wrote:
>
> At present the default log level is set to LOGL_INFO on start-up. Allow
> this to be controlled from Kconfig.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  common/Kconfig | 9 +++++++++
>  common/log.c   | 2 +-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 0a14bdedaa..2ee48e4a2a 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -527,6 +527,15 @@ config TPL_LOG_MAX_LEVEL
>             6 - detail
>             7 - debug
>
> +config LOG_DEFAULT_LEVEL
> +       int "Default logging level to display"
> +       default 5

Shouldn't it be 6 which is LOGL_INFO?

> +       help
> +         This is the default logging level set when U-Boot starts. It can
> +         be adjusted later using the 'log level' command. Note that setting
> +         this to a value abnove LOG_MAX_LEVEL will be ineffective, since the
> +         higher levels are not compiled in to U-Boot.
> +

Other than that,
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin


More information about the U-Boot mailing list