[U-Boot] [PATCH 33/33] x86: Add sound support for samus

[Bin Meng]

Hi Simon,

On Tue, Jan 22, 2019 at 9:14 AM Simon Glass <sjg at chromium.org> wrote:
>
> Enable sound on samus using the broadwell I2S and an RT5677 audio codec.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/x86/dts/chromebook_samus.dts  | 49 +++++++++++++++++++++++++++---
>  configs/chromebook_samus_defconfig |  9 ++++++
>  drivers/sound/Makefile             |  2 +-
>  3 files changed, 55 insertions(+), 5 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Except one comment below:

> diff --git a/arch/x86/dts/chromebook_samus.dts b/arch/x86/dts/chromebook_samus.dts
> index b58936b4ac..ad687ce2cc 100644
> --- a/arch/x86/dts/chromebook_samus.dts
> +++ b/arch/x86/dts/chromebook_samus.dts
> @@ -494,10 +494,20 @@
>                         intel,pre-graphics-delay = <200>;
>                 };
>
> -               me at 16,0 {
> -                       reg = <0x0000b000 0 0 0 0>;
> -                       compatible = "intel,me";
> -                       u-boot,dm-pre-reloc;
> +               adsp at 13,0 {
> +                       reg = <0x00009800 0 0 0 0>;
> +                       compatible = "intel,wildcatpoint-adsp";
> +                       intel,adsp-d3-pg-enable = <0>;
> +                       intel,adsp-sram-pg-enable = <0>;
> +                       intel,sio-acpi-mode;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       i2s: shim {
> +                               compatible = "intel,broadwell-i2s";
> +                               #sound-dai-cells = <1>;
> +                               reg = <0xfb000 0xfc000 0xfd000>;
> +                       };
>                 };
>

[snip]

> diff --git a/drivers/sound/Makefile b/drivers/sound/Makefile
> index a9516e9c03..7b3c879aa2 100644
> --- a/drivers/sound/Makefile
> +++ b/drivers/sound/Makefile
> @@ -17,5 +17,5 @@ obj-$(CONFIG_SOUND_MAX98095)  += max98095.o maxim_codec.o
>  obj-$(CONFIG_SOUND_INTEL_HDA)  += hda_codec.o
>  obj-$(CONFIG_SOUND_I8254)      += i8254_beep.o
>  obj-$(CONFIG_SOUND_RT5677)     += rt5677.o
> -obj-$(CONFIG_INTEL_BROADWELL)  += broadwell_i2s.o #broadwell_sound.o
> +obj-$(CONFIG_INTEL_BROADWELL)  += broadwell_i2s.o broadwell_sound.o

This should be in patch [32/33].

>  obj-$(CONFIG_SOUND_IVYBRIDGE)  += ivybridge_sound.o
> --

Regards,
Bin