[U-Boot] [PATCH v3 07/22] pcm052: board: Remove "m4go" command as it is superseded by "bootaux"

Marcel Ziswiler marcel.ziswiler at toradex.com
Wed Feb 13 14:51:07 UTC 2019


Hi Lukasz

On Sun, 2019-02-03 at 00:02 +0100, Lukasz Majewski wrote:
> The "m4go" provides exactly the same functionality as the IMX generic
> "bootaux" command. Remove it to not duplicate the code.

Makes sense but as far as I can tell from its Kconfig so far bootaux is
only for i.MX 7 and i.MX 6. Should I send a patch for this? Plus you
would also have to enable bootaux support in your defconfig.

Cheers

Marcel

> Signed-off-by: Lukasz Majewski <lukma at denx.de>
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  board/phytec/pcm052/pcm052.c | 38 ----------------------------------
> ----
>  1 file changed, 38 deletions(-)
> 
> diff --git a/board/phytec/pcm052/pcm052.c
> b/board/phytec/pcm052/pcm052.c
> index cfc8009102..4e4b870304 100644
> --- a/board/phytec/pcm052/pcm052.c
> +++ b/board/phytec/pcm052/pcm052.c
> @@ -577,41 +577,3 @@ int checkboard(void)
>  
>  	return 0;
>  }
> -
> -static int do_m4go(cmd_tbl_t *cmdtp, int flag, int argc,
> -		       char * const argv[])
> -{
> -	ulong addr;
> -
> -	/* Consume 'm4go' */
> -	argc--; argv++;
> -
> -	/*
> -	 * Parse provided address - default to load_addr in case not
> provided.
> -	 */
> -
> -	if (argc)
> -		addr = simple_strtoul(argv[0], NULL, 16);
> -	else
> -		addr = load_addr;
> -
> -	/*
> -	 * Write boot address in PERSISTENT_ENTRY1[31:0] aka
> SRC_GPR2[31:0]
> -	 */
> -	writel(addr + 0x401, 0x4006E028);
> -
> -	/*
> -	 * Start secondary processor by enabling its clock
> -	 */
> -	writel(0x15a5a, 0x4006B08C);
> -
> -	return 1;
> -}
> -
> -U_BOOT_CMD(
> -	m4go, 2 /* one arg max */, 1 /* repeatable */, do_m4go,
> -	"start the secondary Cortex-M4 from scatter file image",
> -	"[<addr>]\n"
> -	"    - start secondary Cortex-M4 core using a scatter file
> image\n"
> -	"The argument needs to be a scatter file\n"
> -);


More information about the U-Boot mailing list