[U-Boot] [RFC 1/1] configs: rk3288: SPL file must fit into 32 KiB

[Tom Rini]

On Wed, Feb 13, 2019 at 09:41:30PM +0100, Heinrich Schuchardt wrote:
> 
> 
> On 2/13/19 9:23 PM, Philipp Tomsich wrote:
> > 
> > 
> >> On 13.02.2019, at 21:21, Tom Rini <trini at konsulko.com> wrote:
> >>
> >> On Wed, Feb 13, 2019 at 09:13:05PM +0100, Heinrich Schuchardt wrote:
> >>
> >>> The SPL image for the rk3288 boards has to fit into 32 KiB. This includes
> >>> 4 KiB for the device tree and up to 2 KiB for the file header.
> >>>
> >>> Without the patch we missed to see that the TinkerBoard
> >>> spl/u-boot-spl-dtb.bin file is too big.
> >>>
> >>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> >>
> >> NAK.  To repeat myself in what I said after this patch was already sent,
> >> but for the record, we need to leverage CONFIG_SPL_MAX_SIZE (and
> >> CONFIG_TPL_MAX_SIZE) with the BOARD_SIZE_CHECK logic (and use said logic
> >> more widely) so that we catch this problem everywhere.  A guess at max
> >> DTB size is not enough.  Thanks!
> > 
> > Acknowledged.
> > 
> 
> I have figured out where to put the test but still have to work out the
> details:

Can I suggest taking the logic of BOARD_SIZE_CHECK and making the limit
be an input the function takes?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190213/ae89966c/attachment.sig>