[U-Boot] [PATCH 1/3] mmc: fsl_esdhc: add esdhc_imx flag

Y.b. Lu yangbo.lu at nxp.com
Fri Feb 15 02:28:35 UTC 2019



> -----Original Message-----
> From: Peng Fan
> Sent: Thursday, February 14, 2019 5:11 PM
> To: Y.b. Lu <yangbo.lu at nxp.com>; u-boot at lists.denx.de
> Cc: Jaehoon Chung <jh80.chung at samsung.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>
> Subject: RE: [PATCH 1/3] mmc: fsl_esdhc: add esdhc_imx flag
> 
> 
> 
> > -----Original Message-----
> > From: Y.b. Lu
> > Sent: 2019年2月14日 16:21
> > To: u-boot at lists.denx.de
> > Cc: Jaehoon Chung <jh80.chung at samsung.com>; Prabhakar Kushwaha
> > <prabhakar.kushwaha at nxp.com>; Peng Fan <peng.fan at nxp.com>; Y.b. Lu
> > <yangbo.lu at nxp.com>
> > Subject: [PATCH 1/3] mmc: fsl_esdhc: add esdhc_imx flag
> >
[...]
> > +	/*
> > +	 * This is to specify whether current eSDHC is an i.MX eSDHC,
> > +	 * since the i.MX eSDHC has been becoming more and more different
> > +	 * with QorIQ eSDHC and initial MPC83XX/MPC85XX.
> > +	 */
> > +	if (!fdt_node_check_compatible(fdt, node, "fsl,esdhc"))
> > +		priv->esdhc_imx = true;
> > +	else
> > +		priv->esdhc_imx = false;
> 
> Suggest use device_is_compatible(dev, "fsl,esdhc")
> 
> Regards,
> Peng.
> 

[Y.b. Lu] Sent out v2, and converted to use device_is_compatible().
Thanks a lot.

> > +
> >  	val = dev_read_u32_default(dev, "bus-width", -1);
> >  	if (val == 8)
> >  		priv->bus_width = 8;
> > --
> > 2.17.1



More information about the U-Boot mailing list