[U-Boot] [PATCH v2 1/3] sunxi: Sync Bananapi M2+ device tree from Linux v5.0-rc1

Jagan Teki jagan at amarulasolutions.com
Fri Feb 15 15:24:06 UTC 2019


On Fri, Feb 15, 2019 at 7:46 PM Andre Przywara <andre.przywara at arm.com> wrote:
>
> On Fri, 15 Feb 2019 19:28:20 +0530
> Jagan Teki <jagan at amarulasolutions.com> wrote:
>
> > On Fri, Feb 15, 2019 at 4:33 PM Chen-Yu Tsai <wens at csie.org> wrote:
> > >
> > > As of commit aa8fee415f46 ("ARM: dts: sun8i: h3: Split out
> > > non-SoC-specific parts of Bananapi M2 Plus") in the Linux kernel, the
> > > device tree for the Bananapi M2+ has been split into a common dtsi
> > > file, and an SoC-specific board device tree file that includes both
> > > the shared dtsi file and the soc dtsi file. This was done to support
> > > both the H3 and H5 variants of the same board. This is similar to what
> > > was done for the Libre Computer ALL-H3-CC in U-boot commit
> > > d7b17f1c24af ("sunxi: Split out common board design for ALL-H3-CC
> > > device tree").
> > >
> > > The newly split files are directly synced from Linux tag v5.0-rc1.
> >
> > Based on my previous patch comment, I expected to have full sync with
> > all H3 related files. any plan?
>
> Weren't you dismissing the idea because of "past the MW"?
>
> So coming back to that discussion, I was wondering how DT *updates* are
> actually a new feature (from a U-Boot perspective)?

I would consider as new feature, since I have encountered an mmc issue
due to sync[1] atleast some thing broken with sync during MW.

> Actually I see a lot of warnings from dtc about various things in our
> older .dts's, which spoils buildman runs. From this point of view updating
> the DTs is a mere fix (as they remove these warnings).
> So would you be willing to push for DT updates for this U-Boot release
> still, if I can show that U-Boot is not affected by the DT updates? Stuff
> like adding audio DT nodes have actually zero risk of affecting U-Boot ;-)

I don't believe 100% based on my experience with [1] . I agree with
above lot of warnings older stuff, but I'm considering dts syncs as
part of MW as well to avoid regressions. please see my last PR about
sync[2].

[1] https://www.mail-archive.com/linux-sunxi@googlegroups.com/msg29264.html
[2] https://patchwork.ozlabs.org/patch/976408/


More information about the U-Boot mailing list