[U-Boot] [PATCH v2 7/9] power: regulator: s2mps11: Add enable delay

Krzysztof Kozlowski krzk at kernel.org
Sat Feb 16 08:37:19 UTC 2019


On Fri, Feb 15, 2019 at 06:11:34PM +0100, Simon Glass wrote:
> Hi Krzysztof,
> 
> On Wed, 13 Feb 2019 at 17:47, Krzysztof Kozlowski <krzk at kernel.org> wrote:
> >
> > According to datasheet, the output on LDO regulators will start
> > appearing after 10-15 us.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
> > ---
> >  drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/regulator/s2mps11_regulator.c b/drivers/power/regulator/s2mps11_regulator.c
> > index 723d27f67c9a..1f1581852ee2 100644
> > --- a/drivers/power/regulator/s2mps11_regulator.c
> > +++ b/drivers/power/regulator/s2mps11_regulator.c
> > @@ -551,7 +551,14 @@ static int ldo_get_enable(struct udevice *dev)
> >
> >  static int ldo_set_enable(struct udevice *dev, bool enable)
> >  {
> > -       return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);
> > +       int ret;
> > +
> > +       ret = s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);
> 
> How about:
> 
> if (ret)
>     return ret;
> 

Sure, good idea, thanks!

Best regards,
Krzysztof



More information about the U-Boot mailing list