[U-Boot] net: dm: fec: Fix regulator enable when using DM_REGULATOR

sbabic at denx.de sbabic at denx.de
Sat Feb 16 10:35:56 UTC 2019


> When DM_REGULATOR is enabled, the driver attempts to call
> regulator_autoset() which expects the regulators to be on at boot
> and/or always on and fails if they are not true.
> For a more generic approach, this patch just calls
> regulator_set_enable() which shouldn't have such restrictions.
> Fixes: ad8c43cbcafb ("net: dm: fec: Support the phy-supply
> binding")
> Signed-off-by: Adam Ford <aford173 at gmail.com>
> Tested-by: Martin Fuzzey <martin.fuzzey at flowbird.group>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 32fb34b793..e924ddeb6d 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -1327,7 +1327,7 @@ static int fecmxc_probe(struct udevice *dev)
>  
>  #ifdef CONFIG_DM_REGULATOR
>  	if (priv->phy_supply) {
> -		ret = regulator_autoset(priv->phy_supply);
> +		ret = regulator_set_enable(priv->phy_supply, true);
>  		if (ret) {
>  			printf("%s: Error enabling phy supply\n", dev->name);
>  			return ret;

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================



More information about the U-Boot mailing list