[U-Boot] [PATCH] riscv: fu540: enable SMP

[Auer, Lukas]

On Tue, 2019-02-12 at 05:05 +0000, Anup Patel wrote:
> > -----Original Message-----
> > From: Lukas Auer [mailto:lukas.auer at aisec.fraunhofer.de]
> > Sent: Tuesday, February 12, 2019 4:12 AM
> > To: u-boot at lists.denx.de
> > Cc: Atish Patra <Atish.Patra at wdc.com>; Anup Patel
> > <Anup.Patel at wdc.com>; Bin Meng <bmeng.cn at gmail.com>; Andreas
> > Schwab <schwab at suse.de>; Palmer Dabbelt <palmer at sifive.com>;
> > Alexander Graf <agraf at suse.de>; Lukas Auer
> > <lukas.auer at aisec.fraunhofer.de>; Anup Patel <Anup.Patel at wdc.com>;
> > Atish Patra <Atish.Patra at wdc.com>; Paul Walmsley
> > <paul.walmsley at sifive.com>
> > Subject: [PATCH] riscv: fu540: enable SMP
> > 
> > Hart 0 on the SiFive FU540 is meant for monitoring tasks. It is a
> > E51 core,
> > whereas all other cores are U54 cores. Select hart 1 as the main
> > hart to run U-
> > Boot.
> > 
> > Signed-off-by: Lukas Auer <lukas.auer at aisec.fraunhofer.de>
> > ---
> > This patch depends on the SMP support [1] and the SiFive FU540
> > support
> > patch series [2].
> > I have submitted it independently from the SMP support patch series
> > to
> > allow the series to be merged independently from the SiFive FU540
> > support
> > patch series.
> > 
> > [1]: https://patchwork.ozlabs.org/project/uboot/list/?series=91320
> > [2]: https://patchwork.ozlabs.org/project/uboot/list/?series=91125
> > 
> >  board/sifive/fu540/Kconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/board/sifive/fu540/Kconfig
> > b/board/sifive/fu540/Kconfig index
> > 6be3d88144..d8a6020cf8 100644
> > --- a/board/sifive/fu540/Kconfig
> > +++ b/board/sifive/fu540/Kconfig
> > @@ -16,6 +16,9 @@ config SYS_TEXT_BASE
> >  	default 0x80000000 if !RISCV_SMODE
> >  	default 0x80200000 if RISCV_SMODE
> > 
> > +config MAIN_HART
> > +	default 1
> > +
> >  config BOARD_SPECIFIC_OPTIONS # dummy
> >  	def_bool y
> >  	select GENERIC_RISCV
> > @@ -38,5 +41,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> >  	imply PHY_LIB
> >  	imply PHY_MSCC
> >  	imply SIFIVE_SERIAL
> > +	imply SMP
> > 
> >  endif
> > --
> > 2.20.1
> 
> It will be better if we can get rid off MAIN_HART config option.
> Otherwise, looks good to me.
> 
> Reviewed-by: Anup Patel <anup.patel at wdc.com>
> 

Thanks for your review, Anup!

I will update the patch to remove MAIN_HART together with the next
version of the SMP series.

Thanks,
Lukas