[U-Boot] [PATCH 1/1] added missing GigaDevice chips

[Stefan Roese]

Hi Jiri,

On 18.02.19 10:13, Jiri Kastner wrote:
> ---
>   drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)

Please always add at least a small sentence in the commit text.
And Cc the maintainers / custodians, in this case:

Jagan Teki <jteki at openedev.com>
Vignesh R <vigneshr at ti.com>
  
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 3215e2431d..e4d05433a2 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -106,6 +106,16 @@ const struct flash_info spi_nor_ids[] = {
>   			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>   			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>   	},
> +	{
> +		INFO("gd25q128", 0xc84018, 0, 64 * 1024, 128,

This does not seem to be correct. The kernel version has:

		INFO("gd25q128", 0xc84018, 0, 64 * 1024, 256,

> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},
> +	{
> +		INFO("gd25q256", 0xc84019, 0, 64 * 1024, 128,

And here 512 please.

> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},

Thanks,
Stefan