[U-Boot] [PATCH v2 7/8] spi: sun4: Add A31 spi controller support

Jagan Teki jagan at amarulasolutions.com
Mon Feb 18 09:45:51 UTC 2019


On Fri, Feb 15, 2019 at 5:29 AM André Przywara <andre.przywara at arm.com> wrote:
>
> On 14/02/2019 08:36, Jagan Teki wrote:
>
> Hi,
>
> > Add A31 spi controller support for existing sun4i_spi driver via driver
> > data, this would simply add A31 register along with proper register bits
> > via enum sets.
> >
> > Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> > ---
> >  drivers/spi/Kconfig     |  4 +-
> >  drivers/spi/sun4i_spi.c | 95 ++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 96 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> > index dc561eae4a..c008c5190a 100644
> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -220,9 +220,9 @@ config STM32_QSPI
> >         this ST IP core.
> >
> >  config SUN4I_SPI
>
> I wonder if we should use the opportunity to change this to SUNXI_SPI.
> It's only used one more time in the Makefile, so an easy change.
>
> > -     bool "Allwinner A10 SoCs SPI controller"
> > +     bool "Allwinner A10/A31 SoCs SPI controller"
>
> And H3 and A64, ... So you could just drop the numbers and speak of
> "Allwinner SoCs SPI controllers"

Yes, above two comments can validate in another patch saying detailed
info text of using single driver for all SoC.


More information about the U-Boot mailing list