[U-Boot] [PATCH v2 09/34] gpio: Show inactive GPIOs when explicitly requested

[Simon Glass]

On Mon, 18 Feb 2019 at 02:46, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Sun, Feb 17, 2019 at 11:25 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > At present the gpio command only shows GPIOs which are marked as in use.
> > This makes sense with 'gpio status' since we already have the '-a' flag
> > to indicate that all GPIOs should be shown. But when a particular GPIO is
> > requested, it seems better to always display it. At present the request is
> > simply ignored.
> >
> > For example if GPIO a10 is not in use, then:
> >
> >    > gpio a10
>
> I think this should be "gpio status a10".
>
> >
> > shows nothing, not even the function being used for that GPIO. With this
> > change, it shows the pin status:
> >
> >    > gpio a10
>
> ditto
>
> >    a10: input: 0 [ ]
> >
> > Add an extra parameter for this to avoid changing the existing flag
> > parameter.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v2:
> > - Add an example to the commit message for clarity
> >
> >  cmd/gpio.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> Tested-by: Bin Meng <bmeng.cn at gmail.com>
>
> I can fix that when applying if you don't mind.

Yes please.

>
> Regards,
> Bin