[U-Boot] [PATCH v2 17/34] sandbox: pch: Add a test for the PCH uclass

[Simon Glass]

On Mon, 18 Feb 2019 at 02:46, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Sun, Feb 17, 2019 at 11:26 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > This uclass currently has no tests. Add a sandbox driver and some simple
> > tests to provide basic coverage.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> > ---
> >
> > Changes in v2:
> > - Use "sandbox-pch" for the compatible string, for consistency
>
> I think it should be "sandbox,pch" instead. If you agree, I can fix
> this when applying.

That's fine with me, it is more consistent with what we have.


>
> >
> >  arch/sandbox/dts/test.dts       |  4 ++
> >  arch/sandbox/include/asm/test.h |  8 ++++
> >  drivers/pch/Makefile            |  1 +
> >  drivers/pch/sandbox_pch.c       | 69 +++++++++++++++++++++++++++++++++
> >  test/dm/Makefile                |  1 +
> >  test/dm/pch.c                   | 36 +++++++++++++++++
> >  6 files changed, 119 insertions(+)
> >  create mode 100644 drivers/pch/sandbox_pch.c
> >  create mode 100644 test/dm/pch.c
> >
>
> Regards,
> Bin