[U-Boot] [PATCH v2 1/1] mtd: added missing GigaDevice chips

[Vignesh R]

Hi,

On 18/02/19 3:30 PM, Jiri Kastner wrote:
> Vocore2 (mt7688 based device) has g25q128 chip
> from GigaDevice, which i've found in kernel tree.
> added chips are gd25q128 and gd25q256.
> 
> Cc: Jagan Teki <jteki at openedev.com>
> Cc: Vignesh R <vigneshr at ti.com>
> ---
>  drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 3215e2431d..c1f84df64f 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -106,6 +106,16 @@ const struct flash_info spi_nor_ids[] = {
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>  	},
> +	{
> +		INFO("gd25q128", 0xc84018, 0, 64 * 1024, 256,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},
> +	{
> +		INFO("gd25q256", 0xc84019, 0, 64 * 1024, 512,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},

Have you tested Quad mode on this device? I see gd25q256 uses
macronix_quad_enable() and kernel handles this by .quad_enable()
callback which isnt supported in U-Boot yet. Could you explain how Quad
mode would work in U-Boot with this flash?


-- 
Regards
Vignesh