[U-Boot] [PATCH] configs: dra7xx_evm: Remove ENV_IS_IN_FAT and SPL_ENV_*

Faiz Abbas faiz_abbas at ti.com
Wed Feb 20 08:03:50 UTC 2019


Hi Tom,

On 19/02/19 8:45 PM, Tom Rini wrote:
> On Tue, Feb 19, 2019 at 08:25:29PM +0530, Faiz Abbas wrote:
> 
>> With U-boot supporting environment in multiple places, enable only
>> ENV_IS_IN_EMMC in U-boot.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas at ti.com>
> 
> Since we had previously and intentionally enabled FAT over raw MMC
> location, why the switch back?  Thanks!
> 

This commit added this:

commit fb69464eae1ec5aed2ee0e3a9e5533a31ad38bac
Author: Maxime Ripard <maxime.ripard at free-electrons.com>
Date:   Tue Jan 23 21:17:01 2018 +0100

    env: Allow to build multiple environments in Kconfig

    Now that we have everything in place in the code, let's allow to build
    multiple environments backend through Kconfig.

    Reviewed-by: Andre Przywara <andre.przywara at arm.com>
    Reviewed-by: Lukasz Majewski <lukma at denx.de>
    Reviewed-by: Simon Glass <sjg at chromium.org>
    Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>


Looking at the the cover letter for that series
(https://patchwork.ozlabs.org/cover/842057/) , it seems to be an attempt
to combat the increasing size of U-boot by permanently moving the
environment to FAT partition.

Maybe I am not seeing the whole picture here, but this doesn't make
sense to me. Why should we dictate where every board with MMC storage
puts their environment? Shouldn't we give the freedom for the board
owner to decide that (and work around the ramifications of the
increasing size of U-boot)?

dra7xx has two MMC instances. One is a FAT partitioned SD card and the
other is a raw (or at most GPT partitioned) eMMC. We have been keeping
environment in eMMC to better support android boot requirements and
would like to keep it that way.

Thanks,
Faiz


More information about the U-Boot mailing list