[U-Boot] [PATCH v2 1/1] board: raspberrypi: add serial and revision to the device tree

[Alexander Graf]

On 02/20/2019 05:59 PM, Stephen Warren wrote:
> On 2/20/19 5:09 AM, Anton Gerasimov wrote:
>> Raspberry Pi bootloader adds this node to fdt, but if u-boot script
>> doesn't reuse the tree provided by it, this information is lost.
>>
>> Revision and serial are displayed in /proc/cpuinfo after boot.
>
> Are these properties documented in the upstream Linux kernel in 
> Documentation/devicetree/bindings/? If so, this patch is fine. If not, 
> we should not merge it, since we don't want to pollute the DT with 
> non-standard properties (or: add this to the upstream kernel DT 
> documentation, and then apply this patch once the doc update is 
> approved upstream).


Hm, it almost looks like it's a downstream hack. Unfortunately as U-Boot 
we're in this really weird place where people may want to use it to load 
downstream kernels.

I personally would be perfectly fine to just enable CONFIG_OF_BOARD by 
default and defer people to $fdtcontroladdr. That way, they get the 
firmware patched device tree automatically.


Alex