[U-Boot] [U-Boot, v3, 1/2] fs: fat: dynamically allocate memory for temporary buffer

Michal Simek monstr at monstr.eu
Thu Feb 21 07:45:37 UTC 2019

Hi Tom,

On 20. 02. 19 2:58, Tom Rini wrote:
> On Mon, Feb 11, 2019 at 02:56:19PM +0800, tien.fong.chee at intel.com wrote:
>> From: Tien Fong Chee <tien.fong.chee at intel.com>
>> Drop the statically allocated get_contents_vfatname_block and
>> dynamically allocate a buffer only if required. This saves
>> 64KiB of memory.
>> Signed-off-by: Stefan Agner <stefan.ag... at toradex.com>
>> Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> Applied to u-boot/master, thanks!

please remove this patch (better both of them because they were in
series) because they are breaking at least ZynqMP SPL. It is also too
late in cycle to create random fix.

You can't simply move 64KB from code to malloc without reflecting this
by changing MALLOC space size.

Other boards with SPL fat could be also affected by this if they don't
allocate big malloc space.


Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

More information about the U-Boot mailing list