[U-Boot] [PATCH] am335x-fb: don't override lcd_get_size()

David Rivshin drivshin at awxrd.com
Thu Feb 21 16:05:49 UTC 2019


From: David Rivshin <DRivshin at allworx.com>

am335x-fb overrides the default lcd_get_size() to add an extra 32 bytes
compared to the normal calculation. While the gd->fb_base is an extra 32
bytes larger than the logical framebuffer size, the first 32 bytes is
always skipped. Adding that extra 32 bytes in lcd_get_size() can cause
check_cache_range() (called from lcd_sync(), via flush_dcache_range()) to
output a warning because the end address is not cacheline aligned, even
if the start and real framebuffer size are.

When removing that "+ 0x20" the am335x-fb lcd_get_size() is identical
to the default one, so just delete it altogether.

Signed-off-by: David Rivshin <drivshin at allworx.com>
---
 drivers/video/am335x-fb.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
index 51c1af587f..3a510cf91c 100644
--- a/drivers/video/am335x-fb.c
+++ b/drivers/video/am335x-fb.c
@@ -103,12 +103,6 @@ static struct am335x_lcdhw *lcdhw = (void *)LCD_CNTL_BASE;
 
 DECLARE_GLOBAL_DATA_PTR;
 
-int lcd_get_size(int *line_length)
-{
-	*line_length = (panel_info.vl_col * NBITS(panel_info.vl_bpix)) / 8;
-	return *line_length * panel_info.vl_row + 0x20;
-}
-
 int am335xfb_init(struct am335x_lcdpanel *panel)
 {
 	u32 raster_ctrl = 0;

base-commit: d3689267f92c5956e09cc7d1baa4700141662bff
-- 
2.20.1



More information about the U-Boot mailing list