[U-Boot] [PATCH] imx: ventana: hexdump invalid EEPROM data

Tim Harvey tharvey at gateworks.com
Thu Feb 21 16:48:48 UTC 2019


Signed-off-by: Tim Harvey <tharvey at gateworks.com>
---
 board/gateworks/gw_ventana/eeprom.c | 10 ++++++++++
 configs/gwventana_emmc_defconfig    |  1 +
 configs/gwventana_gw5904_defconfig  |  1 +
 configs/gwventana_nand_defconfig    |  1 +
 4 files changed, 13 insertions(+)

diff --git a/board/gateworks/gw_ventana/eeprom.c b/board/gateworks/gw_ventana/eeprom.c
index ee227320c0..5e9cf11575 100644
--- a/board/gateworks/gw_ventana/eeprom.c
+++ b/board/gateworks/gw_ventana/eeprom.c
@@ -6,6 +6,7 @@
 
 #include <common.h>
 #include <errno.h>
+#include <hexdump.h>
 #include <i2c.h>
 #include <malloc.h>
 #include <asm/bitops.h>
@@ -46,6 +47,8 @@ read_eeprom(int bus, struct ventana_board_info *info)
 	/* sanity checks */
 	if (info->model[0] != 'G' || info->model[1] != 'W') {
 		puts("EEPROM: Invalid Model in EEPROM\n");
+		print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf,
+				     sizeof(*info));
 		return GW_UNKNOWN;
 	}
 
@@ -55,6 +58,8 @@ read_eeprom(int bus, struct ventana_board_info *info)
 	if ((info->chksum[0] != chksum>>8) ||
 	    (info->chksum[1] != (chksum&0xff))) {
 		puts("EEPROM: Failed EEPROM checksum\n");
+		print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf,
+				     sizeof(*info));
 		return GW_UNKNOWN;
 	}
 
@@ -116,6 +121,11 @@ read_eeprom(int bus, struct ventana_board_info *info)
 		else if (info->model[4] == '0' && info->model[5] == '9')
 			type = GW5909;
 		break;
+	default:
+		printf("EEPROM: Unknown model in EEPROM: %s\n", info->model);
+		print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf,
+				     sizeof(*info));
+		break;
 	}
 	return type;
 }
diff --git a/configs/gwventana_emmc_defconfig b/configs/gwventana_emmc_defconfig
index f95957adab..07171c7009 100644
--- a/configs/gwventana_emmc_defconfig
+++ b/configs/gwventana_emmc_defconfig
@@ -85,5 +85,6 @@ CONFIG_USB_ETHER_ASIX=y
 CONFIG_USB_ETHER_SMSC95XX=y
 CONFIG_VIDEO=y
 # CONFIG_VIDEO_SW_CURSOR is not set
+CONFIG_HEXDUMP=y
 CONFIG_OF_LIBFDT=y
 CONFIG_FDT_FIXUP_PARTITIONS=y
diff --git a/configs/gwventana_gw5904_defconfig b/configs/gwventana_gw5904_defconfig
index 219d31a9a1..0ed2209e3b 100644
--- a/configs/gwventana_gw5904_defconfig
+++ b/configs/gwventana_gw5904_defconfig
@@ -89,5 +89,6 @@ CONFIG_USB_ETHER_ASIX=y
 CONFIG_USB_ETHER_SMSC95XX=y
 CONFIG_VIDEO=y
 # CONFIG_VIDEO_SW_CURSOR is not set
+CONFIG_HEXDUMP=y
 CONFIG_OF_LIBFDT=y
 CONFIG_FDT_FIXUP_PARTITIONS=y
diff --git a/configs/gwventana_nand_defconfig b/configs/gwventana_nand_defconfig
index 466a7752ad..57e4a999ab 100644
--- a/configs/gwventana_nand_defconfig
+++ b/configs/gwventana_nand_defconfig
@@ -88,5 +88,6 @@ CONFIG_USB_ETHER_ASIX=y
 CONFIG_USB_ETHER_SMSC95XX=y
 CONFIG_VIDEO=y
 # CONFIG_VIDEO_SW_CURSOR is not set
+CONFIG_HEXDUMP=y
 CONFIG_OF_LIBFDT=y
 CONFIG_FDT_FIXUP_PARTITIONS=y
-- 
2.17.1



More information about the U-Boot mailing list