[U-Boot] [PATCH 02/40] binman: Don't show image-skip message by default

Bin Meng bmeng.cn at gmail.com
Fri Feb 22 07:17:55 UTC 2019


Hi Simon,

On Wed, Jan 30, 2019 at 12:00 PM Simon Glass <sjg at chromium.org> wrote:
>
> This message is not very important since it is simply indicating that the
> user's instructions are being followed. Only show it when the verbosity
> level is above the default.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  tools/binman/control.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/binman/control.py b/tools/binman/control.py
> index 3446e2e79c..b32e4e1996 100644
> --- a/tools/binman/control.py
> +++ b/tools/binman/control.py
> @@ -133,8 +133,8 @@ def Binman(options, args):
>                      if name not in options.image:
>                          del images[name]
>                          skip.append(name)
> -                if skip:
> -                    print 'Skipping images: %s\n' % ', '.join(skip)
> +                if skip and options.verbosity >= 2:
> +                    print 'Skipping images: %s' % ', '.join(skip)

Is dropping '\n' intentional?

>
>              state.Prepare(images, dtb)
>
> --

Regards,
Bin


More information about the U-Boot mailing list