[U-Boot] [RFC PATCH 5/8] arm: actions: add S700 SoC device tree

Amit Tomer amittomer25 at gmail.com
Sun Jan 6 02:16:10 UTC 2019


> Ah, good catch, I agree on the -u-boot.dtsi approach.

Thanks for talking about it( I was expecting this comment)

> Amit, please don't claim it's "sync with Linux" if it isn't. At least
> document this change.

Yeah, I was aware of this situation but rightly so, I should have documented
it in commit messages.
Sorry, I didn't.

> Also there is another instance above, directly on the /soc node.
>
> Maybe we should do as others do and set DM_FLAG_PRE_RELOC on the driver,
> to avoid changing the DT at all?

Yeah, I had something similar in my mind(same was suggested in this
thread[1] few days back)
but wasn't able to test it.

Also, if you see current s900.dtsi in u-boot , it uses those flag in
dtsi itself.

Thanks
-Amit.

[1] : https://lists.denx.de/pipermail/u-boot/2019-January/353438.html

Hate to get up in morning, its cold out here(with bit of rain too) :(


More information about the U-Boot mailing list