[U-Boot] [PATCH 5/8] warp7: defconfig: Switch on IMX7 pinctrl for both ports

[Peng Fan]

> 
> 
> > -----Original Message-----
> > From: Bryan O'Donoghue [mailto:bryan.odonoghue at linaro.org]
> > Sent: 2019年1月3日 9:45
> > To: u-boot at lists.denx.de
> > Cc: Fabio Estevam <fabio.estevam at nxp.com>; Peng Fan
> > <peng.fan at nxp.com>; Bryan O'Donoghue <bryan.odonoghue at linaro.org>;
> > Stefano Babic <sbabic at denx.de>
> > Subject: [PATCH 5/8] warp7: defconfig: Switch on IMX7 pinctrl for both
> > ports
> >
> > Switches on the IMX7 pinctrl driver for the warp7 and warp7_bl33
> > ports, necessary to convert over to DM for this board.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>
> > Cc: Peng Fan <peng.fan at nxp.com>
> > Cc: Fabio Estevam <fabio.estevam at nxp.com>
> > Cc: Stefano Babic <sbabic at denx.de>
> > ---
> >  configs/warp7_bl33_defconfig | 2 ++
> >  configs/warp7_defconfig      | 2 ++
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/configs/warp7_bl33_defconfig
> > b/configs/warp7_bl33_defconfig index b2f943c775..a2c2555315 100644
> > --- a/configs/warp7_bl33_defconfig
> > +++ b/configs/warp7_bl33_defconfig
> > @@ -41,3 +41,5 @@ CONFIG_USB_ETH_CDC=y
> > CONFIG_USBNET_HOST_ADDR="de:ad:be:af:00:00"
> >  CONFIG_OPTEE_TZDRAM_SIZE=0x2000000
> >  CONFIG_DEFAULT_DEVICE_TREE="imx7s-warp"
> > +CONFIG_PINCTRL=y
> > +CONFIG_PINCTRL_IMX7=y
> > diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig index
> > 65d801ffe2..8691d00491 100644
> > --- a/configs/warp7_defconfig
> > +++ b/configs/warp7_defconfig
> > @@ -54,3 +54,5 @@ CONFIG_OPTEE_TZDRAM_SIZE=0x3000000
> >  CONFIG_OPTEE_TZDRAM_BASE=0x9d000000
> >  CONFIG_BOOTM_OPTEE=y
> >  CONFIG_DEFAULT_DEVICE_TREE="imx7s-warp"
> > +CONFIG_PINCTRL=y
> > +CONFIG_PINCTRL_IMX7=y
> 
> Reviewed-by: Peng Fan <peng.fan at nxp.com>

Just have a follow up question,
in patch 4/8, DM MMC is enabled, but in 5/8 pinctrl DM is enabled.
This might be not correct, the DM MMC/PINCTRL/GPIO needs to be in one patch.
The fsl_esdhc DM support does not support DM MMC with legacy iomux code.

Regards,
Peng.
> 
> > --
> > 2.20.0
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> denx.de%2Flistinfo%2Fu-boot&data=02%7C01%7CPeng.Fan%40nxp.co
> m%7Cf6fbfc5331eb4328683308d6756c7489%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C636825506006750873&sdata=iXlXGGewCrW%
> 2B4srkP4d%2BWnZ7UX2AyCK8Tgx93g3SpF8%3D&reserved=0