[U-Boot] dm: pinctrl: Prevent (re-)configuring pins when already done before relocation

Alex Kiernan alex.kiernan at gmail.com
Tue Jan 8 17:49:23 UTC 2019


On Thu, Dec 27, 2018 at 3:49 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, Dec 18, 2018 at 12:30:50PM +0100, Lukasz Majewski wrote:
>
> > This commit prevents from re-configuring pins if those were configured
> > before relocation.
> >
> > Some pins - like UART or DDR must be setup before relocation
> > (as they have 'u-boot,dm-pre-reloc' property set in DTS). Without this
> > change, those pins are re-configured after relocation (pre_reloc_only = 0,
> > so we do not "continue").
> > Such behavior may be a problem for DDR PAD configuration, as they might
> > be already leveled/tuned with original setup).
> >
> > Signed-off-by: Lukasz Majewski <lukma at denx.de>
>
> Applied to u-boot/master, thanks!
>

I've bisected out to this commit and it's slightly broken things for
me on an AM3352. It all works fine so long as I boot MLO from MMC (so
the MMC is probed, pinctrl setup), but if I boot from UART then I get
to full U-Boot, MMC hasn't been probed and the pinmuxing isn't set up
for the MMC.

-- 
Alex Kiernan


More information about the U-Boot mailing list