[U-Boot] [PATCH 0/5] imx8: several fixes

Chris Spencer spencercw at gmail.com
Wed Jan 9 15:42:49 UTC 2019


Stefano,

On Wed, 9 Jan 2019 at 15:14, Stefano Babic <sbabic at denx.de> wrote:
> > https://patchwork.ozlabs.org/patch/1019908/
>
> I have seen this patch to solve "bashism", I confess I had to think
> about what is it. "=" instead of "==" is quite unnatural for me, but
> yes, first thing I do on a new installed system is to run alternative
> and set bash as shell.
>
> Anyway, if this is required, it must be solved globally on the project.
> What about for example scripts/setlocalversion ?
>
> if [ "`hg log -r . --template '{latesttagdistance}'`" == "1" ]; then
>
> I guess there are some other examples in the project. Personally, I tend
> to reject this one, until one goal is to support the major number of
> shells or there will be a list of supported shell (as far as I know, we
> have not even a list of supported distros).

Personally I would tend to take the more standard syntax, but I get
your point. There is another patch from Peng which just makes it run
in bash instead of changing the syntax:

https://patchwork.ozlabs.org/patch/1011510/

> > https://patchwork.ozlabs.org/patch/1016762/
>
> I do not disgregate this, it just under observation - I cannot reproduce
> even with more threads.

Interesting. For what it's worth, Peng did give a 'Reviewed-by' which
wasn't picked up by Patchwork because my message was still in the
moderation queue at that point. Not sure whether he actually managed
to reproduce it though.

https://lists.denx.de/pipermail/u-boot/2018-December/352637.html
https://lists.denx.de/pipermail/u-boot/2018-December/352638.html

Thanks,
Chris


More information about the U-Boot mailing list