[U-Boot] [PATCH 0/5] imx8: several fixes

[Stefano Babic]

On 09/01/19 16:42, Chris Spencer wrote:
> Stefano,
> 
> On Wed, 9 Jan 2019 at 15:14, Stefano Babic <sbabic at denx.de> wrote:
>>> https://patchwork.ozlabs.org/patch/1019908/
>>
>> I have seen this patch to solve "bashism", I confess I had to think
>> about what is it. "=" instead of "==" is quite unnatural for me, but
>> yes, first thing I do on a new installed system is to run alternative
>> and set bash as shell.
>>
>> Anyway, if this is required, it must be solved globally on the project.
>> What about for example scripts/setlocalversion ?
>>
>> if [ "`hg log -r . --template '{latesttagdistance}'`" == "1" ]; then
>>
>> I guess there are some other examples in the project. Personally, I tend
>> to reject this one, until one goal is to support the major number of
>> shells or there will be a list of supported shell (as far as I know, we
>> have not even a list of supported distros).
> 
> Personally I would tend to take the more standard syntax, but I get
> your point. There is another patch from Peng which just makes it run
> in bash instead of changing the syntax:
> 
> https://patchwork.ozlabs.org/patch/1011510/
> 
>>> https://patchwork.ozlabs.org/patch/1016762/
>>
>> I do not disgregate this, it just under observation - I cannot reproduce
>> even with more threads.
> 
> Interesting. For what it's worth, Peng did give a 'Reviewed-by' which
> wasn't picked up by Patchwork because my message was still in the
> moderation queue at that point. Not sure whether he actually managed
> to reproduce it though.

At least, I do not see why this patch should create a new problem. Ok, I
pick it up (as this is a fix), and I add myself Peng's 'Reviewed-by'.

> 
> https://lists.denx.de/pipermail/u-boot/2018-December/352637.html
> https://lists.denx.de/pipermail/u-boot/2018-December/352638.html
> 

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================