[U-Boot] [PATCH 1/2] net: designware: fix tx packet length

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Mon Jan 14 15:35:51 UTC 2019


Joe,

Am 10.12.2018 um 05:08 schrieb Marek Vasut:
> On 12/09/2018 09:50 PM, Simon Goldschmidt wrote:
>> Am 17.11.2018 um 17:02 schrieb Joe Hershberger:
>>> On Sat, Nov 17, 2018 at 3:25 AM Simon Goldschmidt
>>> <simon.k.r.goldschmidt at gmail.com> wrote:
>>>>
>>>> The designware driver has a bug in setting the tx length into the dma
>>>> descriptor: it always or's the length into the descriptor without
>>>> zeroing out the length mask before.
>>>>
>>>> This results in occasional packets being transmitted with a length
>>>> greater than they should be (trailer). Due to the nature of Ethernet
>>>> allowing such a trailer, most packets seem to be parsed fine by remote
>>>> hosts, which is probably why this hasn't been noticed.
>>>>
>>>> Fix this by correctly clearing the size mask before setting the new
>>>> length.
>>>>
>>>> Tested on socfpga gen5.
>>>>
>>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>>>
>>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>>>
>>
>> Marek, this and 2/2 is a assigned to you in patchwork, will you push
>> them or is it Joe's code as u-boot-net maintainer?
> 
> This is net , so Joe should pick it .

I've assigned this one and 2/2 to you in patchwork, is that OK? Could 
you pick these after the release?

Thanks,
Simon



More information about the U-Boot mailing list