[U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

[Fabio Estevam]

Hi Lukasz,

On Mon, Jan 21, 2019 at 12:19 PM Lukasz Majewski <lukma at denx.de> wrote:

> The rationale regarding this approach:
>
> 1. Reuse the clock.c code for iMX6Q as much as possible.

Yes, the problem is that clock.c does not scale well as we have
dedicated clock functions for each peripheral:
enable_uart_clk(), enable_usdhc_clk(), enable_i2c_clk(), etc

If we have a chance to use common clock framework now in U-Boot that
would be a much better implementation and easier to maintain in sync
with the kernel.

> 2, This code is based on the clk-imx8q.c file -  hence the question
> why the Linux clock API was not ported for this new SoC?.

The problem is that up to now no imx clock driver uses the kernel approach.

Barebox uses the kernel approach for all imx SoCs, imx8mq included:
https://git.pengutronix.de/cgit/barebox/tree/drivers/clk/imx/clk-imx8mq.c

> > If we are adding a clock driver for mx6, why don't we add it just like
> > the kernel one?
>
> I can try to port the Linux code, but IMHO it would be feasible to port
> only relevant (ECSPI, USDHC) parts of it (not all as I cannot test it
> all properly).

That would be much appreciated. Thanks