[U-Boot] [RESENT PATCH v3] rockchip: update emmc/sd index for distro boot order

[Kever Yang]

The comment is what we want to do, so it's not correct to fix the
comment only.

    "First try to boot from SD() , then eMMC()"


Thanks,
- Kever
On 01/23/2019 07:00 PM, Philipp Tomsich wrote:
> My gut feeling would be to fix the comment only.
>
>> On 23.01.2019, at 03:14, Kever Yang <kever.yang at rock-chips.com
>> <mailto:kever.yang at rock-chips.com>> wrote:
>>
>> Hi Philipp, Simon,
>>
>>    Is it possible for this patch to be merged?
>>    Right now, two board owner does not  like this patch but both of
>> you says this patch do not affect your board, and most of other
>> boards are maintained by me, and I have share why I need this patch
>> and why this patch not affect so much very clearly in previous mail.
>>     Please evaluate it again and close this topic, at least the
>> original code comment "First try to boot from SD (index 0), then eMMC
>> (index 1) " is not correct, something must be fixed.
>>
>> Thanks,
>> - Kever
>>
>> Kever Yang <kever.yang at rock-chips.com
>> <mailto:kever.yang at rock-chips.com>> 于2018年11月28日周三 上午10:06写道：
>>
>>     According to the emmc/sdcard index in dts alias, emmc is always 0 and
>>     sdcard index is 1, let's update to using correct mmc number for
>>     distro
>>     boot order in common header.
>>
>>     SD card suppost to have higher priority so that people can boot into
>>     the firmware in SD card, this is very convenient for developer
>>     try with
>>     distro img from SUSE, Fedora and etc. Developer only need to 'dd' the
>>     Distro image(which id download from OS vendor release) into SD
>>     card without
>>     any modify and then we can boot it up directly.
>>
>>     Signed-off-by: Kever Yang <kever.yang at rock-chips.com
>>     <mailto:kever.yang at rock-chips.com>>
>>     ---
>>
>>     Changes in v3:
>>     - update the commit message
>>     Series-changes: 2
>>     - update the commit message
>>
>>      include/configs/rockchip-common.h | 6 +++---
>>      1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>     diff --git a/include/configs/rockchip-common.h
>>     b/include/configs/rockchip-common.h
>>     index 68e1105a4b..8a72613e52 100644
>>     --- a/include/configs/rockchip-common.h
>>     +++ b/include/configs/rockchip-common.h
>>     @@ -11,11 +11,11 @@
>>
>>      #ifndef CONFIG_SPL_BUILD
>>
>>     -/* First try to boot from SD (index 0), then eMMC (index 1) */
>>     +/* First try to boot from SD (index 1), then eMMC (index 0) */
>>      #if CONFIG_IS_ENABLED(CMD_MMC)
>>             #define BOOT_TARGET_MMC(func) \
>>     -               func(MMC, mmc, 0) \
>>     -               func(MMC, mmc, 1)
>>     +               func(MMC, mmc, 1) \
>>     +               func(MMC, mmc, 0)
>>      #else
>>             #define BOOT_TARGET_MMC(func)
>>      #endif
>>     -- 
>>     2.18.0
>>
>